Skip to content

fix(reactivity): trigger reactivity for Map key undefined #12055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yyx990803 merged 2 commits into from
Oct 11, 2024
Merged

fix(reactivity): trigger reactivity for Map key undefined #12055

yyx990803 merged 2 commits into from
Oct 11, 2024
+11 −1

Conversation

@jh-leong
Copy link
Member

@jh-leong jh-leong commented Sep 27, 2024

close #12054

@github-actions
Copy link

github-actions bot commented Sep 27, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+17 B) 38.1 kB (+6 B) 34.2 kB (+30 B)
vue.global.prod.js 160 kB (+17 B) 58 kB (+5 B) 51.5 kB (-39 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.1 kB (+17 B) 18.9 kB (+5 B) 17.3 kB (+6 B)
createApp 55.7 kB (+17 B) 21.4 kB (+5 B) 19.6 kB (-32 B)
createSSRApp 59.7 kB (+17 B) 23.1 kB (+6 B) 21 kB (+17 B)
defineCustomElement 60.5 kB (+17 B) 23 kB (+4 B) 20.9 kB (-5 B)
overall 69.4 kB (+17 B) 26.5 kB (+5 B) 24.1 kB (+1 B)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 27, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12055

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12055

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12055

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12055

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12055

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12055

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12055

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12055

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12055

vue

pnpm add https://pkg.pr.new/vue@12055

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12055

commit: b05aa80

@jh-leong
Copy link
Member Author

jh-leong commented Sep 27, 2024

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 27, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools ❌ failure ❌ failure
nuxt ✅ success ✅ success
pinia ✅ success ✅ success
primevue ✅ success ✅ success
quasar ✅ success ✅ success
radix-vue ✅ success ✅ success
router ✅ success ✅ success
test-utils ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vitepress ✅ success ✅ success
vue-i18n ✅ success ✅ success
vue-macros ❌ failure ❌ failure
vuetify ✅ success ✅ success
vueuse ❌ failure ❌ failure
vue-simple-compiler ✅ success ✅ success

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: reactivity labels Sep 27, 2024
@yyx990803 yyx990803 merged commit 7ad289e into vuejs:main Oct 11, 2024
@jh-leong jh-leong deleted the fix/12054 branch October 11, 2024 15:25
abdullah-wn pushed a commit to Lazy-work/vue that referenced this pull request Jan 4, 2025
@jh-leong @abdullah-wn
fix(reactivity): trigger reactivity for Map key undefined (vuejs#12055
53a15d4 
)

close vuejs#12054
johnleider added a commit to vuetifyjs/vuetify that referenced this pull request Mar 20, 2025
@johnleider
docs(prop-load-children): add unique id for users
7c33933 
will bug out for users with Vue < 3.5.12 vuejs/core#12055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: reactivity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Computed map.get with key undefined is not reactive

4 participants

@jh-leong @vue-bot @yyx990803 @edison1105